Skip to content

Conversation

@LaBatata101
Copy link
Contributor

Summary

Fixes #18107

Test Plan

Snapshot tests

@github-actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@AlexWaygood AlexWaygood changed the title [pylint] Fix PLW1514 not recognizing the enconding positional argument of codecs.open [pylint] Fix PLW1514 not recognizing the encoding positional argument of codecs.open May 15, 2025
@ntBre ntBre added bug Something isn't working fixes Related to suggested fixes for violations labels May 15, 2025
Copy link
Contributor

@ntBre ntBre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ntBre ntBre merged commit f53c580 into astral-sh:main May 15, 2025
34 checks passed
@LaBatata101 LaBatata101 deleted the fix-PLW1514 branch May 15, 2025 23:55
Glyphack pushed a commit to Glyphack/ruff that referenced this pull request May 21, 2025
…gument of `codecs.open` (astral-sh#18109)

<!--
Thank you for contributing to Ruff/ty! To help us out with reviewing,
please consider the following:

- Does this pull request include a summary of the change? (See below.)
- Does this pull request include a descriptive title? (Please prefix
with `[ty]` for ty pull
  requests.)
- Does this pull request include references to any relevant issues?
-->

## Summary

Fixes astral-sh#18107
<!-- What's the purpose of the change? What does it do, and why? -->

## Test Plan

Snapshot tests
<!-- How was it tested? -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fixes Related to suggested fixes for violations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PLW1514 doesn’t recognize encoding positional argument of codecs.open

2 participants