-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update salsa #18212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update salsa #18212
Conversation
|
|
sharkdp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! (also for making that change in salsa)
4c341d0 to
66ad41b
Compare
|
this change caused a regression with |
|
This looks like a network issue rather than a problem with the pr itself |
I reproduced it on my Windows machine too. also retries didn't help |
|
Any chance you're behind a proxy? Or have otherwise limited network access? Can you open the url in your browser? |
yes, I can. there shouldn't be a proxy on Windows machine... anyway I'll open a PR now which updates salsa to stable version |
|
We prefer to keep the git dependency as we're still very actively developing salsa |
Summary
Update salsa.
The biggest change is that salsa no longer automatically derives
PartialOrdandOrdfor salsa-structs. Instead, an explicit#[derive(PartialOrd, Ord)]is requiredto opt in to the ID based ordering.
Test Plan
cargo test