[ty] Fix multithreading related hangs and panics #18238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
MichaReiser
force-pushed
the
micha-verify-hang
branch
3 times, most recently
from
f07152c to
1dcebfe
Compare
Contributor
|
MichaReiser
force-pushed
the
micha-verify-hang
branch
2 times, most recently
from
33933a8 to
1428243
Compare
MichaReiser
changed the title
MichaReiser
changed the title
MichaReiser
changed the title
MichaReiser
changed the title
MichaReiser
commented
May 29, 2025
Comment on lines
+7
to
+8
| discord.py | ||
| freqtrade |
Member
Author
There was a problem hiding this comment.
I'll move them to good in a separate commit
MichaReiser
force-pushed
the
micha-verify-hang
branch
2 times, most recently
from
e22ca10 to
76dee37
Compare
MichaReiser
force-pushed
the
micha-verify-hang
branch
from
76dee37 to
940339c
Compare
MichaReiser
commented
Jun 1, 2025
| #[cfg(not(debug_assertions))] | ||
| #[cfg(target_pointer_width = "64")] | ||
| static_assertions::assert_eq_size!(Type, [u8; 24]); | ||
| static_assertions::assert_eq_size!(Type, [u8; 16]); |
Member
Author
There was a problem hiding this comment.
Nice @ibraheemdev some of your recent changes reduced the size of Type again!
Member
There was a problem hiding this comment.
Huh, that's interesting. The only change to the stack types was that Id is now aligned to 4-bytes instead of 8.
Member
Author
|
I'll merge this. I can't see how this would be controversial 😆 but happy to address any feedback post merge |
MichaReiser
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
dcreager
added a commit
that referenced
this pull request
Jun 2, 2025
…aration * origin/main: [ty] Treat lambda functions as instances of types.FunctionType (#18431) [ty] Fix false positives for legacy `ParamSpec`s inside `Callable` type expressions (#18426) [ty] Improve diagnostics if the user attempts to import a stdlib module that does not exist on their configured Python version (#18403) Update taiki-e/install-action action to v2.52.4 (#18420) Update docker/build-push-action action to v6.18.0 (#18422) [ty] Fix server hang after shutdown request (#18414) Update Rust crate libcst to v1.8.0 (#18424) Update Rust crate clap to v4.5.39 (#18419) Update cargo-bins/cargo-binstall action to v1.12.6 (#18416) Update dependency mdformat-mkdocs to v4.3.0 (#18421) Update pre-commit dependencies (#18418) Update dependency ruff to v0.11.12 (#18417) [ty] Ensure `Literal` types are considered assignable to anything their `Instance` supertypes are assignable to (#18351) [ty] Promote projects to good that now no longer hang (#18370) Sync vendored typeshed stubs (#18407) [ty] Fix multithreading related hangs and panics (#18238) Support relative `--ty-path` in ty-benchmark (#18385) [ty] Update docs for Python version inference (#18397) [ty] Infer the Python version from the environment if feasible (#18057) Implement template strings (#17851)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in salsa-rs/salsa#882 which fixes multiple multithreaded fixpoint related hangs and panics
Test plan
#18370