Skip to content

[ty] Fix panic when trying to pull types for attribute expressions inside Literal type expressions #18535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2025
Merged

[ty] Fix panic when trying to pull types for attribute expressions inside Literal type expressions #18535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/ty_project/resources/test/corpus/literal_slices.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
from typing import Literal

class Format:
STRING = "string"

def evaluate(format: Literal[Format.STRING]) -> str: ...
4 changes: 0 additions & 4 deletions crates/ty_project/tests/check.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,18 +304,14 @@ const KNOWN_FAILURES: &[(&str, bool, bool)] = &[

// These are all "expression should belong to this TypeInference region and TypeInferenceBuilder should have inferred a type for it"
("crates/ty_vendored/vendor/typeshed/stdlib/abc.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/annotationlib.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/ast.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/builtins.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/curses/__init__.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/dataclasses.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/inspect.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/lzma.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/os/__init__.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/pathlib/__init__.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/pathlib/types.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/pstats.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/signal.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/socket.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/sqlite3/__init__.pyi", true, true),
("crates/ty_vendored/vendor/typeshed/stdlib/tempfile.pyi", true, true),
Expand Down
6 changes: 4 additions & 2 deletions crates/ty_python_semantic/src/types/infer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9468,11 +9468,13 @@ impl<'db> TypeInferenceBuilder<'db, '_> {
ast::Expr::Attribute(ast::ExprAttribute { value, attr, .. }) => {
let value_ty = self.infer_expression(value);
// TODO: Check that value type is enum otherwise return None
value_ty
let ty = value_ty
.member(self.db(), &attr.id)
.place
.ignore_possibly_unbound()
.unwrap_or(Type::unknown())
.unwrap_or(Type::unknown());
self.store_expression_type(parameters, ty);
ty
}
// for negative and positive numbers
ast::Expr::UnaryOp(u)
Expand Down
Loading