Skip to content

Conversation

@sharkdp
Copy link
Contributor

@sharkdp sharkdp commented Jun 23, 2025

Summary

As far as I can tell, the two existing tests did the exact same thing. Remove the redundant test, and add tests for all combinations of declared/not-declared and local/"public" use of the name.

Proposing this as a separate PR before the behavior might change via #18750

@sharkdp sharkdp added the ty Multi-file analysis & type inference label Jun 23, 2025
@github-actions
Copy link
Contributor

mypy_primer results

No ecosystem changes detected ✅

@AlexWaygood AlexWaygood added the testing Related to testing Ruff itself label Jun 23, 2025
@sharkdp sharkdp merged commit 21303d1 into main Jun 23, 2025
37 checks passed
@sharkdp sharkdp deleted the david/builtin-shadowing-tests branch June 23, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Related to testing Ruff itself ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants