[pyupgrade] Prevent infinite loop with I002 and UP026
#20327
Merged
+73
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
dylwil3
requested changes
Sep 12, 2025
Collaborator
dylwil3
left a comment
dylwil3
left a comment
There was a problem hiding this comment.
Looks good, just a few nits - thank you!
crates/ruff_linter/src/rules/pyupgrade/rules/deprecated_mock_import.rs
Outdated
Show resolved
Hide resolved
dylwil3
changed the title
pyupgrade] Prevent infinite loop with I002 and UP026pyupgrade] Prevent infinite loop with I002 and UP026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #19842
Prevent infinite loop with I002 and UP026
Test Plan
I have added two integration tests
pyupgrade_up026_respects_isort_required_import_fixandpyupgrade_up026_respects_isort_required_import_from_fixincrates/ruff/tests/lint.rs.