[ty] allow any string Literal type expression as a key when constructing a TypedDict
#20792
+48
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cting a `TypedDict`
Contributor
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
Contributor
|
mtshiba
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
Member
FWIW I think the spec only states this for I think we can also update our bidirectional inference code, which makes the same assumption. |
carljm
pushed a commit
that referenced
this pull request
Oct 10, 2025
…ucting a `TypedDict` (#20806) ## Summary Based on @ibraheemdev's comment on #20792: > I think we can also update our bidirectional inference code, [which makes the same assumption](https://github.com/astral-sh/ruff/blob/main/crates/ty_python_semantic/src/types/infer/builder.rs?rgh-link-date=2025-10-09T21%3A30%3A31Z#L5860). This PR also adds more test cases for how `TypedDict` annotations affect generic call inference. ## Test Plan New tests in `typed_dict.md`
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows any string
Literaltype expression to be used as a key when constructing aTypedDict.The pattern of reusing constant key strings when constructing a
TypedDictseems to be common in several libraries (e.g., home-assistant/core).Currently, we only accept string literal keys when constructing a
TypedDict, but any expression that can be inferred to be of type stringLiteralis also acceptable. In fact, the spec explicitly states thatLiteraltype expressions andFinalnames should be allowed.Test Plan
New tests in
typed_dict.md