[ty] Reformat constraint set mdtests #21111
Merged
+547
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcreager
requested review from
AlexWaygood,
carljm and
sharkdp
as code owners
dcreager
added
internal
MichaReiser
approved these changes
Oct 28, 2025
dcreager
changed the base branch from
dcreager/subtype-given-typevars
to
main
dcreager
force-pushed
the
dcreager/refactor-constraint-mdtests
branch
from
afee27e to
fd7f4b5
Compare
Member
Author
|
Rebased this onto |
dcreager
added a commit
that referenced
this pull request
Oct 28, 2025
…straint-sets * dcreager/subtype-given-typevars: better comment restructure a bit better names/comments simplify before implication two typevars! [ty] Reformat constraint set mdtests (#21111) [ty] Move constraint set mdtest functions into `ConstraintSet` class (#21108) Avoid sending an unnecessary "clear diagnostics" message for clients supporting pull diagnostics (#21105) Update Rust crate ignore to v0.4.24 (#20979)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the mdtests that test how our generics solver interacts with our new constraint set implementation. Because the rendering of a constraint set can get long, this standardizes on putting the
revealedassertion on a separate line. We also add astatic_asserttest for each constraint set to verify that they are all coerced into simplebools correctly.This is a pure reformatting (not even a refactoring!) that changes no behavior. I've pulled it out of #20093 to reduce the amount of effort that will be required to review that PR.