[pylint] unspecified-encoding (W1514) #3416
Conversation
| // If `open` has been rebound, skip this check entirely. | ||
| if !checker.ctx.is_builtin(OPEN_FUNC_NAME) { | ||
| return; | ||
| } | ||
| // Look for open(). | ||
| if !matches!(&func.node, ExprKind::Name {id, ..} if id == OPEN_FUNC_NAME) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Nit: I recommend switching the is_builtin check and testing the function name because testing is_builtin is more expensive than comparing two strings
| // If `open` has been rebound, skip this check entirely. | |
| if !checker.ctx.is_builtin(OPEN_FUNC_NAME) { | |
| return; | |
| } | |
| // Look for open(). | |
| if !matches!(&func.node, ExprKind::Name {id, ..} if id == OPEN_FUNC_NAME) { | |
| return; | |
| } | |
| // Look for open(). | |
| if !matches!(&func.node, ExprKind::Name {id, ..} if id == OPEN_FUNC_NAME) { | |
| return; | |
| } | |
| // If `open` has been rebound, skip this check entirely. | |
| if !checker.ctx.is_builtin(OPEN_FUNC_NAME) { | |
| return; | |
| } |
| } | ||
|
|
||
| // Check encoding for missing or None values. | ||
| let encoding_arg = call_args.get_argument(ENCODING_KEYWORD_ARGUMENT, Some(3)); |
There was a problem hiding this comment.
Nit: I recommend inlining the ENCODING_KEYWORD_ARGUMENT constant because it is only used once and it can break the reading flow if I have to jump to the top to understand what the value of the constant is.
| open(FILENAME, "w", encoding="utf-8") | ||
| open(FILENAME, "wb") | ||
| open(FILENAME, "w+b") | ||
| open(FILENAME) # [unspecified-encoding] |
There was a problem hiding this comment.
One issue here is that this rule is in conflict with UP015, which removes redundant open modes (so, e.g., it changes open("foo", "r") to open("foo")). We'd have to mark these rules as incompatible in the INCOMPATIBLE_CODES slice in crates/ruff/src/registry.rs.
|
Closing to keep the pull request queue up-to-date -- we'd have to resolve some incompatibilities with existing rules here. |
Partially addresses #3278
Implements the core features for w1514, including having
"b"in themodearg.Not all fixtures work properly, in particular:
open()open(x, encoding=y)