Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't suggest replacing builtin.open() with Path.open() if the latter doesn't support all options #7637

Merged
merged 2 commits into from
Sep 26, 2023

Review

b64b4a1
Select commit
Loading
Failed to load commit list.
Merged

Don't suggest replacing builtin.open() with Path.open() if the latter doesn't support all options #7637

Review
b64b4a1
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis succeeded Sep 26, 2023

Performance Gate Passed

Summary

⚡ 5 improvements
✅ 20 untouched benchmarks

Benchmarks breakdown

Benchmark main fix-gh7620 Change
linter/default-rules[large/dataset.py] 94.1 ms 90.7 ms +3.77%
lexer[numpy/ctypeslib.py] 2 ms 1.9 ms +2.55%
lexer[unicode/pypinyin.py] 620.1 µs 592 µs +4.74%
lexer[large/dataset.py] 9.8 ms 9 ms +8.46%
lexer[pydantic/types.py] 4.1 ms 4 ms +3.69%