Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CellOffsets abstraction #8814

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Add CellOffsets abstraction #8814

merged 3 commits into from
Nov 22, 2023

Conversation

dhruvmanila
Copy link
Member

Refactor Notebook::cell_offsets to use an abstract struct for storing the cell
offsets. This will allow us to add useful methods on it.

@dhruvmanila
Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Nov 21, 2023
Merged
Merged
@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label Nov 21, 2023
charliermarsh
charliermarsh approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great idea.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2023 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Base automatically changed from dhruv/cell to main November 22, 2023 15:21
@dhruvmanila dhruvmanila enabled auto-merge (squash) November 22, 2023 15:22
@dhruvmanila dhruvmanila merged commit 727e389 into main Nov 22, 2023
16 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/cell-offsets branch November 22, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhruvmanila @charliermarsh