Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid B015,B018 for last expression in a cell #8815

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Avoid B015,B018 for last expression in a cell #8815

merged 5 commits into from
Nov 22, 2023

Conversation

dhruvmanila
Copy link
Member

Summary

This PR updates B015 and B018 to ignore last top-level expressions in each
cell of a Jupyter Notebook.

Part of #8669

Test Plan

Add test cases for both rules and update the snapshots.

@dhruvmanila dhruvmanila mentioned this pull request Nov 21, 2023
Merged
@dhruvmanila
Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@dhruvmanila dhruvmanila mentioned this pull request Nov 21, 2023
Merged
@dhruvmanila dhruvmanila added the rule Implementing or modifying a lint rule label Nov 21, 2023
charliermarsh
charliermarsh approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Base automatically changed from dhruv/cell-offsets to main November 22, 2023 15:27
@dhruvmanila dhruvmanila enabled auto-merge (squash) November 22, 2023 15:28
@dhruvmanila dhruvmanila merged commit 5b726f7 into main Nov 22, 2023
16 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/notebook-b015-b018 branch November 22, 2023 15:33
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@miccal miccal mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhruvmanila @charliermarsh