-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VIRTUAL_ENV
is set to wrong directory when using pyproject-file
config
#251
Comments
VIRTUAL_ENV
is set to wrong directory which is not relative to given pyproject-file
VIRTUAL_ENV
is set to wrong directory when using pyproject-file
config
How should this anyways work with projects having multiple sub-pyprojects? |
When I implemented the pyproject-file input I was not thinking about monorepos.
tl;dr: It doesn't. This action needs breaking changes in order to fix this bug. Might take me a while to find a way which doesn't lead to more breaking changes a few weeks after... |
Would it be possible to have option to skipping the setting of this env? |
If you DON'T use |
We are getting warnings:
warning: VIRTUAL_ENV=/home/runner/work/my_repo/my_proj/.venv does not match the project environment path .venv and will be ignored
The
VIRTUAL_ENV
seems to be pointing to wrong place which is not under the defined pyproject:Shouldnt the
VIRTUAL_ENV
in this case be pointing toVIRTUAL_ENV=/home/runner/work/my_repo/my_proj/my_subproject/.venv
?Issue seems to be originating here
setup-uv/src/setup-uv.ts
Line 165 in 2098017
VIRTUAL_ENV
should be relative to the definedpyproject-file
directory, right?The text was updated successfully, but these errors were encountered: