-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion on mistyped uv python
command suggests uv pip
#8313
Labels
bug
Something isn't working
Comments
Thanks! This looks weirdly hard to fix. |
zanieb
added a commit
that referenced
this issue
Oct 18, 2024
…and error (#8316) Part of #8313 I think we'll need to open an issue upstream to add more context to the error here, because there's not sufficient information about the parent command to provide a good error message. As a first step, let's avoid giving these suggestions for subcommands that overlap with our top-level commands.. because that's just confusing. Here's all the information we have here ```rust [crates/uv/src/lib.rs:1530:13] &err = ErrorInner { kind: InvalidSubcommand, context: FlatMap { keys: [ InvalidSubcommand, Usage, ], values: [ String( "remove", ), StyledStr( StyledStr( "\u{1b}[1m\u{1b}[32mUsage:\u{1b}[0m \u{1b}[1m\u{1b}[36muv python\u{1b}[0m \u{1b}[36m[OPTIONS]\u{1b}[0m \u{1b}[36m<COMMAND>\u{1b}[0m", ), ), ], }, message: None, source: None, help_flag: Some( "--help", ), styles: Styles { header: Style { fg: Some( Ansi( Green, ), ), bg: None, underline: None, effects: Effects(BOLD), }, error: Style { fg: Some( Ansi( Red, ), ), bg: None, underline: None, effects: Effects(BOLD), }, usage: Style { fg: Some( Ansi( Green, ), ), bg: None, underline: None, effects: Effects(BOLD), }, literal: Style { fg: Some( Ansi( Cyan, ), ), bg: None, underline: None, effects: Effects(BOLD), }, placeholder: Style { fg: Some( Ansi( Cyan, ), ), bg: None, underline: None, effects: Effects(), }, valid: Style { fg: Some( Ansi( Green, ), ), bg: None, underline: None, effects: Effects(), }, invalid: Style { fg: Some( Ansi( Yellow, ), ), bg: None, underline: None, effects: Effects(), }, }, color_when: Auto, color_help_when: Auto, backtrace: None, } ```
MtkN1
pushed a commit
to MtkN1/uv
that referenced
this issue
Oct 21, 2024
…and error (astral-sh#8316) Part of astral-sh#8313 I think we'll need to open an issue upstream to add more context to the error here, because there's not sufficient information about the parent command to provide a good error message. As a first step, let's avoid giving these suggestions for subcommands that overlap with our top-level commands.. because that's just confusing. Here's all the information we have here ```rust [crates/uv/src/lib.rs:1530:13] &err = ErrorInner { kind: InvalidSubcommand, context: FlatMap { keys: [ InvalidSubcommand, Usage, ], values: [ String( "remove", ), StyledStr( StyledStr( "\u{1b}[1m\u{1b}[32mUsage:\u{1b}[0m \u{1b}[1m\u{1b}[36muv python\u{1b}[0m \u{1b}[36m[OPTIONS]\u{1b}[0m \u{1b}[36m<COMMAND>\u{1b}[0m", ), ), ], }, message: None, source: None, help_flag: Some( "--help", ), styles: Styles { header: Style { fg: Some( Ansi( Green, ), ), bg: None, underline: None, effects: Effects(BOLD), }, error: Style { fg: Some( Ansi( Red, ), ), bg: None, underline: None, effects: Effects(BOLD), }, usage: Style { fg: Some( Ansi( Green, ), ), bg: None, underline: None, effects: Effects(BOLD), }, literal: Style { fg: Some( Ansi( Cyan, ), ), bg: None, underline: None, effects: Effects(BOLD), }, placeholder: Style { fg: Some( Ansi( Cyan, ), ), bg: None, underline: None, effects: Effects(), }, valid: Style { fg: Some( Ansi( Green, ), ), bg: None, underline: None, effects: Effects(), }, invalid: Style { fg: Some( Ansi( Yellow, ), ), bg: None, underline: None, effects: Effects(), }, }, color_when: Auto, color_help_when: Auto, backtrace: None, } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I typed:
I'd expect that the "similar subcommand" would be
uv python uninstall
rather thanuv pip uninstall
.uv 0.4.23 (Homebrew 2024-10-17)
The text was updated successfully, but these errors were encountered: