Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv tree: extra packages are listed as roots #8516

Closed
bluss opened this issue Oct 24, 2024 · 1 comment · Fixed by #8532
Closed

uv tree: extra packages are listed as roots #8516

bluss opened this issue Oct 24, 2024 · 1 comment · Fixed by #8532
Assignees
Labels
bug Something isn't working

Comments

@bluss
Copy link
Contributor

bluss commented Oct 24, 2024

new uv tree features are looking good. Here's one change from before that could maybe be a bug.

uv init jc
# Initialized project `jc` at `/home/user/jc`
cd jc
uv add --frozen jupyter-client
uv tree
Resolved 12 packages in 186ms
cffi v1.17.1
└── pycparser v2.22
jc v0.1.0
└── jupyter-client v8.6.3
    ├── jupyter-core v5.7.2
    │   ├── platformdirs v4.3.6
    │   └── traitlets v5.14.3
    ├── python-dateutil v2.9.0.post0
    │   └── six v1.16.0
    ├── pyzmq v26.2.0
    ├── tornado v6.4.1
    └── traitlets v5.14.3

Expected: There is one root 'jc'. Actual: There are two roots 'cffi' and 'jc'.
'cffi' comes from this resolution: cffi==1.17.1 ; implementation_name == 'pypy' and it will be in its right spot in the tree if we run uv tree --universal

uv tree --universal
Resolved 12 packages in 0.59ms
jc v0.1.0
└── jupyter-client v8.6.3
    ├── jupyter-core v5.7.2
    │   ├── platformdirs v4.3.6
    │   ├── pywin32 v308
    │   └── traitlets v5.14.3
    ├── python-dateutil v2.9.0.post0
    │   └── six v1.16.0
    ├── pyzmq v26.2.0
    │   └── cffi v1.17.1
    │       └── pycparser v2.22
    ├── tornado v6.4.1
    └── traitlets v5.14.3
@zanieb zanieb added the bug Something isn't working label Oct 24, 2024
@charliermarsh
Copy link
Member

That does look wrong, thanks.

@charliermarsh charliermarsh self-assigned this Oct 24, 2024
charliermarsh added a commit that referenced this issue Oct 24, 2024
## Summary

We were including dependencies that were only included by a dependency
that isn't relevant on the current platform (i.e., we were enforcing the
"current environment" at one level, but not transitively).

Closes #8516.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants