Add support for --prefix
#4085
Merged
Add support for --prefix
#4085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
the
compatibility
charliermarsh
force-pushed
the
charlie/prefix
branch
from
3f22f69
to
64939e6
Compare
charliermarsh
force-pushed
the
charlie/prefix
branch
4 times, most recently
from
89ee399
to
6c920c3
Compare
charliermarsh
force-pushed
the
charlie/prefix
branch
from
6c920c3
to
598686f
Compare
This was referenced Jun 25, 2024
charliermarsh
pushed a commit
that referenced
this pull request
Jun 25, 2024
## Summary In #4085, support was implemented for the `--prefix` option. When using this option, however, a lock is either acquired on the virtualenv or globally, preventing multiple installs to different `--prefix`s from the same interpreter. In this change, acquire the lock on just the prefix in question. ## Test Plan Ran a `uv pip install` with `--prefix` and `RUST_LOG=trace` and observed that the lock was acquired in the prefix.
charliermarsh
pushed a commit
that referenced
this pull request
Jun 25, 2024
## Summary Since #4085, `--prefix` has been implemented and thus is no longer a compatibility. ## Test Plan N/a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3076.