Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch more node types from the dbt Manifest #598

Closed
tatiana opened this issue Oct 13, 2023 · 1 comment
Closed

Fetch more node types from the dbt Manifest #598

tatiana opened this issue Oct 13, 2023 · 1 comment
Labels
area:parsing Related to parsing DAG/DBT improvement, issues, or fixes area:rendering Related to rendering, like Jinja, Airflow tasks, etc

Comments

@tatiana
Copy link
Collaborator

tatiana commented Oct 13, 2023

Sometimes, depending on the node type, the dbt manifest declares them in the root key nodes. However, in some cases (such as sources and exposures, dbt lists them using dedicated keys at the same level as nodes.

The goal for this ticket is to check all DbtResourceType items defined in cosmos.constants and try to find them in the root of the manifest file. This is particularly relevant since users can extend the definition of DbtResourceType by using DbtResourceType("newtype"), as part of #503.

This is a follow up to:
#503 (comment)

@tatiana tatiana added area:parsing Related to parsing DAG/DBT improvement, issues, or fixes area:rendering Related to rendering, like Jinja, Airflow tasks, etc labels Nov 8, 2023
Copy link

dosubot bot commented Feb 7, 2024

Hi, @tatiana,

I'm helping the Cosmos team manage their backlog and am marking this issue as stale. The issue you raised involves broadening the types of nodes retrieved from the dbt Manifest, specifically identifying all DbtResourceType items defined in cosmos.constants and locating them in the root of the manifest file. It seems to be a continuation of a prior GitHub discussion, and there have been no further updates or activity reported on this issue.

Could you please confirm if this issue is still relevant to the latest version of the Cosmos repository? If it is, please let the Cosmos team know by commenting on the issue. Otherwise, feel free to close the issue yourself, or it will be automatically closed in 7 days.

Thank you for your understanding and cooperation.

I (Dosu)

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Feb 7, 2024
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 14, 2024
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:parsing Related to parsing DAG/DBT improvement, issues, or fixes area:rendering Related to rendering, like Jinja, Airflow tasks, etc
Projects
None yet
Development

No branches or pull requests

1 participant