Changelog, raise error if no dataset kwd found in MastMissions, coverage

Author: snbianco

CHANGES.rst

@@ -30,6 +30,10 @@ mast
 
 - Switch to use HTTP continuation for partial downloads. [#3448]
 
+- Add ``batch_size`` parameter to ``MastMissions.get_product_list``, ``Observations.get_product_list``,
+  and ``utils.resolve_object`` to allow controlling the number of items sent in each batch request to the server.
+  This can help avoid timeouts or connection errors for large requests. [#3454]
+
 
 Infrastructure, Utility and Other Changes and Additions
 -------------------------------------------------------

astroquery/mast/missions.py

@@ -409,9 +409,9 @@ def get_product_list_async(self, datasets, batch_size=1000):
         if isinstance(datasets, Table) or isinstance(datasets, Row):
             dataset_kwd = self.get_dataset_kwd()
             if not dataset_kwd:
-                log.warning(f'Dataset keyword not found for mission {self.mission}. '
-                            'Please input dataset IDs as a string, list of strings, or `~astropy.table.Column`.')
-                return None
+                error_msg = (f'Dataset keyword not found for mission "{self.mission}". '
+                             'Please input dataset IDs as a string, list of strings, or `~astropy.table.Column`.')
+                raise InvalidQueryError(error_msg)
 
         # Extract dataset IDs based on input type and mission
         if isinstance(datasets, Table):

astroquery/mast/observations.py

@@ -537,7 +537,8 @@ def get_product_list_async(self, observations, batch_size=500):
             observations = observations['obsid'].tolist()
 
         # Clean and validate
-        observations = [str(obs).strip() for obs in observations if str(obs).strip()]
+        observations = [str(obs).strip() for obs in observations]
+        observations = [obs for obs in observations if obs]
         if not observations:
             raise InvalidQueryError('Observation list is empty, no associated products.')
 

astroquery/mast/tests/test_mast.py

@@ -330,6 +330,11 @@ def test_missions_get_product_list_async(patch_post):
         mast.MastMissions.get_product_list_async([' '])
     assert 'Dataset list is empty' in str(err_empty.value)
 
+    # No dataset keyword
+    with pytest.raises(InvalidQueryError, match='Dataset keyword not found for mission "invalid"'):
+        missions = mast.MastMissions(mission='invalid')
+        missions.get_product_list_async(Table({'a': [1, 2, 3]}))
+
 
 def test_missions_get_product_list(patch_post):
     # String input