Upstream fix for "Investigate replacing spectrum1d unit conversion in cubeviz parser" #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1181 +/- ##
=======================================
Coverage 86.86% 86.87%
=======================================
Files 63 63
Lines 4553 4556 +3
=======================================
+ Hits 3955 3958 +3
Misses 598 598 ☔ View full report in Codecov by Sentry. |
rosteen
approved these changes
Oct 11, 2024
|
Thanks for the review and approval! On the Jdaviz side, what specutils version should we bump to to get this patch? |
I'll do a 1.17.1 release since this was a bug. |
|
Actually maybe do a 1.18.0 instead after #1184 is resolved? Thanks! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If accepted, after merge, will need a PR over at Jdaviz to use this and bump specutils pin.
If rejected, hack-fix Jdaviz to overwrite uncertainty after calling
with_flux_unitfrom specutils. No need to bump specutils pin.🐱