Updated documentation in __init__.py #809
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "bug" comes up a few times a year, where users find that their calculated coordinates seem to be no-sensical on their actual screen sizes. This is just due to higher pixel density on retina display macs. This has an easy work around of dividing x and y coordinates by 2. I explored ways to automate checks for whether retina display was present but didn't want to add any additional dependencies to the project or risk breaking projects that use the existing work around. I've just added a warning to the doc-string of the size() function in innit.py warning users that if they are using a retina display mac book, they can expect a pixel density of 2x2, meaning they will most likely have to divide x and y coordinates by 2 to get their desired position. This way there is an official notice in the project so that people don't keep posting it as an issue here.