Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed detection of scrot #83

Merged
merged 4 commits into from
Mar 18, 2017
Merged

fixed detection of scrot #83

merged 4 commits into from
Mar 18, 2017

Conversation

jose1711
Copy link
Contributor

subprocess.Popen(['which','scrot'], stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True).wait()
255
vs
subprocess.Popen(['which scrot'], stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True).wait()
0

>>> subprocess.Popen(['which','scrot'], stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True).wait()
255
 vs
>>> subprocess.Popen(['which scrot'], stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True).wait()
0
should make it work everywhere

>>> subprocess.Popen(['which','scrot'], stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True).wait()
255
>>> subprocess.Popen(['which','scrot'], stdout=subprocess.PIPE, stderr=subprocess.PIPE).wait()
0
on linux (this unbreaks sushigoroundbot). maim is a new dependency - also
it appears to be faster than scrot
@asweigart asweigart merged commit c77fa73 into asweigart:master Mar 18, 2017
@asweigart
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants