Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update to new parser api #746

Merged
merged 10 commits into from
Aug 30, 2023
Merged

Conversation

jonaslagoni
Copy link
Member

Description
This PR updates the library to the newest parser API, and effectively adds support for v3 (at least it can understand v3).

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@jonaslagoni
Copy link
Member Author

FYI, I had to update to webpack 5 to make it work, but don't see that as a downside 😆

@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni
Copy link
Member Author

@fmvilas @derberg @magicmatatjahu all tests finally pass and it builds correctly, please have a look when you can 🙏

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jonaslagoni
Copy link
Member Author

@fmvilas I am leaving merging to you folks.

@fmvilas
Copy link
Member

fmvilas commented Aug 30, 2023

Are you afraid of something? 😄

@fmvilas
Copy link
Member

fmvilas commented Aug 30, 2023

/rtm

@fmvilas
Copy link
Member

fmvilas commented Aug 30, 2023

/rtm

@fmvilas fmvilas merged commit eabba4f into asyncapi:next Aug 30, 2023
9 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.49 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants