-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: update to new parser api #746
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
FYI, I had to update to webpack 5 to make it work, but don't see that as a downside 😆 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@fmvilas @derberg @magicmatatjahu all tests finally pass and it builds correctly, please have a look when you can 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@fmvilas I am leaving merging to you folks. |
Are you afraid of something? 😄 |
/rtm |
/rtm |
🎉 This PR is included in version 1.0.0-next.49 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR updates the library to the newest parser API, and effectively adds support for v3 (at least it can understand v3).