Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove messageId from v3 conversion #201

Closed
jonaslagoni opened this issue Nov 4, 2023 · 3 comments
Closed

Remove messageId from v3 conversion #201

jonaslagoni opened this issue Nov 4, 2023 · 3 comments
Labels
area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers

Comments

@jonaslagoni
Copy link
Member

Reason/Context

As messageId now will be removed, we need to also remove it from the conversion to v3.

This can be achieved by altering the convertMessages function to now more generically also remove messageId along side the schema union changes:

Object.entries(messages).forEach(([_, message]) => {

Feel free to reach out if you have any questions

Related spec issue: asyncapi/spec#978

@jonaslagoni jonaslagoni added the enhancement New feature or request label Nov 4, 2023
@jonaslagoni
Copy link
Member Author

/gfi typescript

@asyncapi-bot asyncapi-bot added area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers labels Nov 4, 2023
@devilkiller-ag
Copy link
Member

Hi, Can I work on this issue?

@jonaslagoni
Copy link
Member Author

Fixed by #202.

Sorry @devilkiller-ag, maybe this peak your interest #195?

Feel free to ask follow up questions and ask for more specific descriptions on the issue 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants