Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add docker support to action directly #375

Merged
merged 15 commits into from
Jan 15, 2024

Conversation

Shurtu-gal
Copy link
Collaborator

@Shurtu-gal Shurtu-gal commented Jan 9, 2024

Description

  • Update README to use official names as per marketplace instead of docker-image
  • Add support for a bump of version in action.yml version.

Related issue(s)
Fixes #374, #368

@Shurtu-gal Shurtu-gal self-assigned this Jan 9, 2024
@Shurtu-gal
Copy link
Collaborator Author

Successful workflow run :- https://github.com/ash17290/test-experiment/actions/runs/7464972818/job/20313136124

As can be seen with the new one docker image is directly pulled saving precious time.

@Shurtu-gal
Copy link
Collaborator Author

@Shurtu-gal Shurtu-gal marked this pull request as ready for review January 9, 2024 20:55
@Shurtu-gal Shurtu-gal requested a review from derberg January 9, 2024 20:58
README.md Outdated Show resolved Hide resolved
.releaserc Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@derberg
Copy link
Member

derberg commented Jan 10, 2024

ping me when you need another review

@Shurtu-gal
Copy link
Collaborator Author

@derberg It is ready for review now

@Shurtu-gal Shurtu-gal requested a review from derberg January 11, 2024 09:45
Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Shurtu-gal Shurtu-gal linked an issue Jan 11, 2024 that may be closed by this pull request
@Shurtu-gal
Copy link
Collaborator Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 01993be into asyncapi:master Jan 15, 2024
22 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docker support for GitHub action github-action-for-generator: Error: Found non-callable @@iterator
3 participants