Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add example to use custom enum value name #764

Merged
merged 7 commits into from
Jun 21, 2022
Merged

docs: add example to use custom enum value name #764

merged 7 commits into from
Jun 21, 2022

Conversation

jonaslagoni
Copy link
Member

Description
This example is to showcase and answer https://stackoverflow.com/questions/72530361/asyncapi-enum-with-specific-values

@coveralls
Copy link

coveralls commented Jun 7, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2535748816

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.105%
Totals Coverage Status
Change from base Build 2535744759: 0.0%
Covered Lines: 2806
Relevant Lines: 2904
💛 - Coveralls

@jonaslagoni jonaslagoni mentioned this pull request Jun 9, 2022
Merged
magicmatatjahu
magicmatatjahu previously approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! However, we I think that we should change chore to the docs, even if you added new example.

@jonaslagoni
Copy link
Member Author

LGTM! However, we I think that we should change chore to the docs, even if you added new example.

True, changing :)

@jonaslagoni jonaslagoni changed the title chore: add example to use custom enum value name docs: add example to use custom enum value name Jun 13, 2022
@jonaslagoni
Copy link
Member Author

Wtf, seems like the npm cache is poisoned or something, cant make it work. Gonna try to commit an empty change.

@magicmatatjahu
Copy link
Member

@jonaslagoni Yeah, I see that also on other PRs, but as I see they try to fix it actions/setup-node#516

@jonaslagoni
Copy link
Member Author

jonaslagoni commented Jun 13, 2022 •
edited
Loading

@magicmatatjahu lets just wait for the fix then, no rush and I dont want to start changing the CI back and forth.

@magicmatatjahu
Copy link
Member

@jonaslagoni You can merge it :)

@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni jonaslagoni merged commit 1a1728a into asyncapi:master Jun 21, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.59.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jonaslagoni jonaslagoni deleted the feature/add_new_csharp_enum_example branch May 22, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonaslagoni @coveralls @magicmatatjahu @asyncapi-bot