Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add script to convert md to mdx #2938

Merged
merged 10 commits into from
May 14, 2024
Merged

feat: add script to convert md to mdx #2938

merged 10 commits into from
May 14, 2024

Conversation

akshatnema
Copy link
Member

@akshatnema akshatnema commented May 5, 2024 •
edited
Loading

Description

Added new scripts to convert md files to mdx at build time.

Related issue(s)

@netlify Netlify
Copy link

netlify bot commented May 5, 2024 •
edited
Loading

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 80b5247
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/664237538496b700084f9dc4
😎 Deploy Preview https://deploy-preview-2938--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@quetzalliwrites
Copy link
Member

Whoa 🤯 , 236 file changes? Is that really a safe way to make changes? If that amount of file changes is not a mistake, shouldn't we be breaking this up into MANY smaller PRs?

@akshatnema
Copy link
Member Author

Whoa 🤯 , 236 file changes? Is that really a safe way to make changes? If that amount of file changes is not a mistake, shouldn't we be breaking this up into MANY smaller PRs?

If we look into the changes, there are actually none. I've only added a new script to build pages inside website.

@anshgoyalevil
Copy link
Member

anshgoyalevil commented May 11, 2024 •
edited
Loading

A neat workaround 🥳

A minor bug,

  • HTML tables aren't rendering correctly

@akshatnema
Copy link
Member Author

HTML tables aren't rendering correctly

Resolved this bug ✅

anshgoyalevil
anshgoyalevil reviewed May 11, 2024
View reviewed changes
Copy link
Member

@anshgoyalevil anshgoyalevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me 🚀

Need a final review from @derberg

@akshatnema
Copy link
Member Author

Also from @alequetzalli too 😅😊

derberg
derberg reviewed May 13, 2024
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we remove what's in pages (taken from markdown dir) entirely? and have it in .gitignore for local development?

@akshatnema
Copy link
Member Author

@derberg We actually moved the files, if you look into the changes. Also, you can checkout the PR locally to see if there are files inside pages folder or not.

image

@derberg derberg changed the title feat: added script to convert md to mdx feat: add script to convert md to mdx May 13, 2024
derberg
derberg previously approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshatnema right, sorry, all good from my side

@akshatnema
Copy link
Member Author

@derberg @anshgoyalevil Can you please approve the PR again? 😅

quetzalliwrites
quetzalliwrites approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good 👍🏽👾

@anshgoyalevil
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 5543592 into asyncapi:migrate-ts May 14, 2024
14 checks passed
@Shurtu-gal Shurtu-gal mentioned this pull request May 17, 2024
Merged
Shurtu-gal added a commit to Shurtu-gal/cli that referenced this pull request May 17, 2024
@Shurtu-gal
chore(ci): change pages to markdown w.r.t. asyncapi/website#2938
4dbbfb4
This was referenced May 17, 2024
Closed
Merged
Merged
Merged
Merged
@akshatnema akshatnema deleted the fix-mdx branch October 11, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshgoyalevil anshgoyalevil anshgoyalevil approved these changes

@quetzalliwrites quetzalliwrites quetzalliwrites approved these changes

@derberg derberg derberg approved these changes

@thulieblack thulieblack Awaiting requested review from thulieblack

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu

@Mayaleeeee Mayaleeeee Awaiting requested review from Mayaleeeee

@sambhavgupta0705 sambhavgupta0705 Awaiting requested review from sambhavgupta0705

@BhaswatiRoy BhaswatiRoy Awaiting requested review from BhaswatiRoy

@J0SAL J0SAL Awaiting requested review from J0SAL

@octonawish-akcodes octonawish-akcodes Awaiting requested review from octonawish-akcodes

@TRohit20 TRohit20 Awaiting requested review from TRohit20

@VaishnaviNandakumar VaishnaviNandakumar Awaiting requested review from VaishnaviNandakumar

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akshatnema @quetzalliwrites @anshgoyalevil @derberg @asyncapi-bot