-
-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed dashboard scripts #3304
Merged
asyncapi-bot
merged 10 commits into
asyncapi:master
from
akshatnema:fix-build-dashboard-scripts
Oct 23, 2024
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c8e5b24
Removed promise from build-dashboard
akshatnema 2888676
Updated script with pause in the scripts
akshatnema 4058ced
excluded some pause in the script
akshatnema d762073
updated dashboard to update the pause and add Promises
akshatnema f2c1e1a
Added extra pause in getHotDiscussions
akshatnema fca64ae
Merge branch 'master' into fix-build-dashboard-scripts
asyncapi-bot 0f14a3d
added a optional chaining
akshatnema 339ac4f
removed Twitter embed from newsroom page
akshatnema 433f38d
refactored build-dashboard script
akshatnema 79611d1
Merge branch 'master' into fix-build-dashboard-scripts
anshgoyalevil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Simplify Error Handling by Throwing Errors Directly
In
async
functions, instead of returningPromise.reject(e);
, it's cleaner to throw the error directly usingthrow e;
. This makes the code more idiomatic and easier to read.Apply this diff:
Also applies to: 59-59
🧰 Tools
🪛 GitHub Check: codecov/patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will improve this readiness of the code in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akshatnema, understood. Would you like me to open a new GitHub issue to track this improvement?
🐰😔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure 👍 . Please do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akshatnema, I've opened a new GitHub issue to track this improvement: Issue #3305.
🐰😊
🔗 Analysis chain
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 597