Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: algolia search icon on homepage #3373

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

fix: algolia search icon on homepage #3373

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c364685
fixed algolia search icon on homepage
amanbhoria Nov 7, 2024
12afe08
Merge branch 'master' into fixAlgoSearch
amanbhoria Nov 8, 2024
55528ab
Merge branch 'master' into fixAlgoSearch
amanbhoria Nov 8, 2024
baa94ef
Merge branch 'master' into fixAlgoSearch
amanbhoria Nov 8, 2024
2e19f66
Merge branch 'master' into fixAlgoSearch
amanbhoria Nov 9, 2024
6791234
initial commit
amanbhoria Nov 10, 2024
e9b34d1
Update NavBar.tsx
amanbhoria Nov 10, 2024
2570d9a
Merge branch 'master' into fixAlgoSearch
amanbhoria Nov 10, 2024
4155980
Update NavBar.tsx
amanbhoria Nov 10, 2024
6100fab
Merge branch 'master' into fixAlgoSearch
amanbhoria Nov 11, 2024
1be152f
Merge branch 'master' into fixAlgoSearch
amanbhoria Nov 12, 2024
0362dfb
Merge branch 'master' into fixAlgoSearch
amanbhoria Nov 12, 2024
0cad639
Merge branch 'master' into fixAlgoSearch
asyncapi-bot Nov 20, 2024
116ab5f
Merge branch 'master' into fixAlgoSearch
amanbhoria Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/navigation/NavBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ export default function NavBar({ className = '', hideLogo = false }: NavBarProps
className='mr-2 flex items-center space-x-2 rounded-md p-2 text-left text-gray-400 transition duration-150 ease-in-out hover:bg-gray-100 hover:text-gray-500 focus:bg-gray-100 focus:text-gray-500 focus:outline-none'
aria-label='Open Search'
>
<IconLoupe />
{() => <IconLoupe />}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amanbhoria can you please elaborate this change a little

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sambhavgupta0705 As you can see in the useEffect, type of children is expected as a function, but it was a node earlier. That's the reason why Algolia search icon was not visible.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amanbhoria Can we change the useEffect function then, to fix this rendering?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@akshatnema As it can handle both the searches on landing page simultaneously. Can we do something like that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, can you please try that and see if we are facing any errors or not.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as the search's concern, everything seems to be working.

</SearchButton>

{/* // Language Picker Component */}
Expand Down
Loading