Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of table scrolling of FUI 2.9 #1988

Open
mkrecek234 opened this issue Jan 30, 2023 · 7 comments
Open

Make use of table scrolling of FUI 2.9 #1988

mkrecek234 opened this issue Jan 30, 2023 · 7 comments

Comments

@mkrecek234
Copy link
Contributor

FUI 2.9 offers table scrolling as described in https://fomantic-ui.com/collections/table.html#scrolling
Eventually this can help to improve addJsPaginatorInContainer as the current implementation has some issues (e.g. does not support added total line, or added decorators etc.), so we could re-use FUI as much as possible.

@mvorisek mvorisek changed the title Make use of table scrolling of FUI 2.9 Make use of table scrolling of FUI 2.9 Jan 30, 2023
@mvorisek
Copy link
Member

When non JS paginator is used, no scrolling should be probably present.

What is the improved objective here?

@mkrecek234
Copy link
Contributor Author

This is just an idea to make use of FUI scrolling class, instead of Atk4 proprietary HTML rendering in scrolling plugin. This eventually might improve FUI compatibility for scrolling feature as it is natively supported in FUI 2.9.

@mvorisek
Copy link
Member

We use plugin to load data dynamically, FUI cannot do that. How can the scrolling help?

@mvorisek
Copy link
Member

mvorisek commented Feb 6, 2023

Is this FR related with infinite/JS scrolling only?

instead of Atk4 proprietary HTML ... as it is natively supported in FUI 2.9

Please provide concrete screenshots of design/behaviour now and after this FR you expect.

@mvorisek
Copy link
Member

mvorisek commented Feb 9, 2023

I would like to have the tables resizeable like textarea - https://stackoverflow.com/questions/11163981/div-resizable-like-text-area

@lubber-de
Copy link

I would like to have the tables resizeable like textarea - stackoverflow.com/questions/11163981/div-resizable-like-text-area

Like that? 😉
fomantic/Fomantic-UI#2748

@mvorisek
Copy link
Member

mvorisek commented May 12, 2023

related with fomantic/Fomantic-UI#2785

setTableHeader() {
if (this.$el.parent().length > 0) {
let $tableCopy = null;
this.$el.parent().height(this.settings.options.tableContainerHeight);
this.$el.addClass('fixed');
$tableCopy = this.$el.clone(true, true);
$tableCopy.attr('id', $tableCopy.attr('id') + '_');
$tableCopy.find('tbody, tfoot').remove();
$tableCopy.css({
position: 'absolute',
'background-color': this.settings.options.tableHeaderColor,
border: this.$el.find('th').eq(1).css('border-left'),
'z-index': 1,
});
this.$scroll.prepend($tableCopy);
this.$el.find('thead').hide();
this.$el.css('margin-top', $tableCopy.find('thead').height());
}
}

should not be needed anymore then, demo demos/interactive/scroll-grid-container.php, would also probably fix #646

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants