From ffed30906dad2f30ec580699102aa948b2f2bd69 Mon Sep 17 00:00:00 2001 From: "Andre A. Gomes" Date: Thu, 19 Oct 2023 14:58:19 +0300 Subject: [PATCH 1/6] buffer: Review status buffer style. Uniformize hover and active CSS pseudo classes across all interactive UI elements. Make use of new theme color and ditch opacity hacks. Review tabs UI. --- source/buffer.lisp | 26 ++++++++------------------ 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/source/buffer.lisp b/source/buffer.lisp index bdd268e425d..a4d8032cd19 100644 --- a/source/buffer.lisp +++ b/source/buffer.lisp @@ -918,10 +918,6 @@ Also see `panel-page'.")) :margin-left "-8px") `("#reload" :width "24px !important") - `("#controls > button:hover" - :background-color ,theme:accent - :color ,theme:on-accent - :opacity "1.0") `("#url" :background-color ,theme:primary :color ,theme:on-primary @@ -952,9 +948,8 @@ Also see `panel-page'.")) `("#tabs::-webkit-scrollbar" :display "none") `(".tab" - :background-color ,theme:background + :background-color ,theme:background- :color ,theme:on-background - :opacity 0.6 :display "inline-block" :margin-top "1px" :padding-left "18px" @@ -967,9 +962,6 @@ Also see `panel-page'.")) :font "inherit" :outline "inherit" :clip-path "polygon(calc(100% - 10px) 0, 100% calc(50% - 1px), 100% 50%, 100% calc(50% + 1px), calc(100% - 10px) 100%, 0% 100%, 10px calc(50% + 1px), 10px 50%, 10px calc(50% - 1px), 0% 0%)") - `(".tab:hover" - :opacity 0.8 - :cursor "pointer") `("#modes" :background-color ,theme:primary :color ,theme:on-primary @@ -990,18 +982,16 @@ Also see `panel-page'.")) :padding 0 :font "inherit" :outline "inherit") - `(.button.action + `((:and (:or .button .tab) :hover) + :cursor "pointer" :background-color ,theme:action :color ,theme:on-action) - `((:and .button :hover) - :cursor "pointer" - :opacity 0.6) - `((:and .button (:or :visited :active)) - :color ,theme:background) + `((:and (:or .button .tab) :active) + :background-color ,theme:action- + :color ,theme:on-action) `(.selected-tab - :color ,theme:on-background - :opacity "1.0 !important" - :background-color ,theme:background)))) + :background-color ,theme:action+ + :color ,theme:on-action)))) (:export-class-name-p t) (:export-accessor-names-p t) (:export-predicate-name-p t) From cbb91a3a643e9420756c69e77051246b3d77e40c Mon Sep 17 00:00:00 2001 From: John Mercouris Date: Sat, 28 Oct 2023 15:15:27 -0500 Subject: [PATCH 2/6] buffer.lisp: Remove deprecated comment. Status buffer was switched to flexbox, columns were from grid. --- source/buffer.lisp | 1 - 1 file changed, 1 deletion(-) diff --git a/source/buffer.lisp b/source/buffer.lisp index a4d8032cd19..1faaa0daced 100644 --- a/source/buffer.lisp +++ b/source/buffer.lisp @@ -901,7 +901,6 @@ Also see `panel-page'.")) :margin-left "-10px") `("#container" :display "flex" - ;; Columns: controls, url, tabs, modes :justify-content "space-between" :overflow-y "hidden") `("#controls" From 77b0afee4c5477f6f01597fc678d90e243380726 Mon Sep 17 00:00:00 2001 From: John Mercouris Date: Sat, 28 Oct 2023 15:21:10 -0500 Subject: [PATCH 3/6] buffer.lisp: Make whole #url area clickable. --- source/buffer.lisp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/source/buffer.lisp b/source/buffer.lisp index 1faaa0daced..627b177893e 100644 --- a/source/buffer.lisp +++ b/source/buffer.lisp @@ -930,6 +930,9 @@ Also see `panel-page'.")) :flex-grow "3" :flex-shrink "2" :flex-basis "144px") + `("#url button" + :text-align "left" + :width "100%") `("#tabs" :background-color ,theme:secondary :color ,theme:on-secondary @@ -981,7 +984,7 @@ Also see `panel-page'.")) :padding 0 :font "inherit" :outline "inherit") - `((:and (:or .button .tab) :hover) + `((:and (:or .button .tab "#url") :hover) :cursor "pointer" :background-color ,theme:action :color ,theme:on-action) From 21ab2990eb9ae23e2691587cb57498f9c4ad24b8 Mon Sep 17 00:00:00 2001 From: John Mercouris Date: Sat, 28 Oct 2023 15:39:08 -0500 Subject: [PATCH 4/6] buffer.lisp: Tweak color of selected tab. --- source/buffer.lisp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source/buffer.lisp b/source/buffer.lisp index 627b177893e..63a7a7cad74 100644 --- a/source/buffer.lisp +++ b/source/buffer.lisp @@ -992,8 +992,8 @@ Also see `panel-page'.")) :background-color ,theme:action- :color ,theme:on-action) `(.selected-tab - :background-color ,theme:action+ - :color ,theme:on-action)))) + :background-color ,theme:background+ + :color ,theme:on-background)))) (:export-class-name-p t) (:export-accessor-names-p t) (:export-predicate-name-p t) From f1ab2de84c2df33dae96e2b78a26afbe81b22ff3 Mon Sep 17 00:00:00 2001 From: John Mercouris Date: Sat, 28 Oct 2023 15:40:43 -0500 Subject: [PATCH 5/6] buffer.lisp: Change padding left for controls. --- source/buffer.lisp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/buffer.lisp b/source/buffer.lisp index 63a7a7cad74..ece9ca5a0a3 100644 --- a/source/buffer.lisp +++ b/source/buffer.lisp @@ -906,7 +906,7 @@ Also see `panel-page'.")) `("#controls" :background-color ,theme:secondary :color ,theme:on-secondary - :padding-left "10px" + :padding-left "8px" :overflow "hidden" :white-space "nowrap" :z-index "3" From 304417b2f4e653395b17a9cbdb52ddfd8fff0ccb Mon Sep 17 00:00:00 2001 From: John Mercouris Date: Sat, 28 Oct 2023 15:43:11 -0500 Subject: [PATCH 6/6] changelog.lisp: Add information about changes to Status area. --- source/changelog.lisp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/source/changelog.lisp b/source/changelog.lisp index 276df5db54f..c13acb50ca5 100644 --- a/source/changelog.lisp +++ b/source/changelog.lisp @@ -909,6 +909,11 @@ Nyxt version exists. It is only raised when the major version differs.") (:nxref :command 'nyxt/mode/prompt-buffer:toggle-attributes-display) " and behavior of UI elements relying on it.")))) +(define-version "3.X.Y" + (:nsection :title "UI/UX" + (:ul + (:li "Simplify status bar CSS. Make URL area clickable.")))) + (define-version "4-pre-release-1" (:li "When on pre-release, push " (:code "X-pre-release") " feature in addition to " (:code "X-pre-release-N") "one."))