Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused prompter source slots #30

Open
jmercouris opened this issue Apr 30, 2021 · 2 comments
Open

Unused prompter source slots #30

jmercouris opened this issue Apr 30, 2021 · 2 comments

Comments

@jmercouris
Copy link
Member

The following slots were removed from prompter-source, they may be useful in the future.

   (multiline nil                     ; TODO: Unused?
              :type (or boolean integer)
              :documentation
              "If non-nil, each candidate can span over multiple lines.
If an integer, it specifies the maximum number of lines allow per candidate.")

   (requires-pattern 0                ; TODO: Use!
                     :documentation
                     "Compute and display suggestions only if the pattern has
at least this number of characters.  When 0, always compute and display
suggestions.")

    (suggestion-limit 0       ; TODO: Implement.  Move to Nyxt's prompt-buffer?
                      :documentation
                      "Don't display more suggestions than this.
 If 0, there is no limit.")

jmercouris referenced this issue in atlas-engineer/nyxt Apr 30, 2021
We don't want to export slots we might delete in the future.
@aadcg
Copy link
Member

aadcg commented Aug 23, 2022

Do we still need this issue? @Ambrevar @jmercouris

@Ambrevar
Copy link
Member

Ambrevar commented Sep 1, 2022

Yup, these are nice features that I'd like to implement when I get back to hacking on the prompter.
Unless someone beats me to it.

Note: John removed the slots in commit 4a94f9202606a9eff32e512ee3b5a848e30d003e.

@aadcg aadcg transferred this issue from atlas-engineer/nyxt Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants