NONE: Re-enable eslint rules #2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgvozdev
reviewed
Nov 20, 2023
| @@ -40,7 +40,7 @@ export const GithubServerAppMiddleware = async (req: Request, res: Response<any, | |||
| res.locals.gitHubAppId = gitHubServerApp.id; | |||
| res.locals.gitHubAppConfig = { | |||
| gitHubAppId: gitHubServerApp.id, | |||
| appId: gitHubServerApp.appId, | |||
| appId: String(gitHubServerApp.appId), | |||
There was a problem hiding this comment.
Just wondering about the justification of this change :) Could you please clarify in a few words? 🙏
There was a problem hiding this comment.
The parent object is now more strongly typed. In other usage it is used as a String this makes this invocation consistent with that typing expectation
bgvozdev
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Lint
Why
Lint
Added feature flags
None
Affected issues
NONE
How has this been tested?
Tests
Whats Next?
Lint