Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@smashwilson
Copy link
Contributor

@smashwilson smashwilson commented Aug 30, 2018

npm has published a few minor versions since the last upgrade landed. Here are the changelogs:

I don't see anything too critical in there, but it'll help us stay on top of upstream bugfixes 🐛 🔨

Remaining work
  • Bump ye version
  • Tag a prerelease and send a PR to atom/atom including it
  • Verify that the new version does not break Squirrel

@daviwil
Copy link
Contributor

daviwil commented Aug 30, 2018

When I tried 6.3.0 the deduping behavior seemed to be worse and apm's dependencies in Atom weren't being flattened as much as with 6.2.0. Not sure if that was just a fluke, but something worth keeping an eye on

@smashwilson
Copy link
Contributor Author

Oh, right - I thought I remembered you having some problems with that. I should cut a prerelease and try a speculative Atom PR to make sure 6.4.1 works well with Squirrel and such.

Atom's VSTS build caught the deduping problems, right?

@smashwilson
Copy link
Contributor Author

Also: I'm deliberately not including this in the v2.1.1 release I'm bringing to Atom in atom/atom#17953 so that we can ship #812 in the next beta hotfix with minimal risk. This is just a "while I'm in here" sort of change, so no big deal if we need to just punt it for later.

@daviwil
Copy link
Contributor

daviwil commented Aug 30, 2018

VSTS probably won't give an error unless the paths become much longer. I was checking the path lengths by installing a build on Windows and using PowerShell to get the lengths of the longest 10 paths. Once you get a PR going on atom/atom I can check the Windows artifact later and see if we're good.

No worries! Thanks for keeping this up to date ⚡

@smashwilson
Copy link
Contributor Author

Ahh, got it - I'll ping you on the PR once it's up.

[..] using PowerShell to get the lengths of the longest 10 paths [..]

Think it would be worth committing this somewhere as a script? I could test on my Windows box downstairs too.

@daviwil
Copy link
Contributor

daviwil commented Aug 30, 2018

Yep, that'd also save me from having to re-remember it every time ;)

@daviwil
Copy link
Contributor

daviwil commented Aug 30, 2018

Now that I think about it, might be good to have a path length test in the Windows CI script so that we get some indication of how it changes over time and maybe fail the build if it exceeds a predefined goal length we've set. I'll put together something for that later!

@smashwilson
Copy link
Contributor Author

image

@smashwilson
Copy link
Contributor Author

Just make sure we don't spend more effort on this than it would take to... fix Squirrel to use Windows long path names. 😆

@daviwil
Copy link
Contributor

daviwil commented Aug 30, 2018

I think fixing Squirrel is probably going to be more of a pain, but I haven't tried it yet :)

@DeeDeeG
Copy link
Contributor

DeeDeeG commented May 8, 2020

Just popping in to say this is obsoleted as of #887.

@aminya aminya mentioned this pull request Aug 23, 2020
@aminya aminya mentioned this pull request Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants