-
Notifications
You must be signed in to change notification settings - Fork 294
Update npm #813
Update npm #813
Conversation
|
When I tried 6.3.0 the deduping behavior seemed to be worse and apm's dependencies in Atom weren't being flattened as much as with 6.2.0. Not sure if that was just a fluke, but something worth keeping an eye on |
|
Oh, right - I thought I remembered you having some problems with that. I should cut a prerelease and try a speculative Atom PR to make sure 6.4.1 works well with Squirrel and such. Atom's VSTS build caught the deduping problems, right? |
|
Also: I'm deliberately not including this in the v2.1.1 release I'm bringing to Atom in atom/atom#17953 so that we can ship #812 in the next beta hotfix with minimal risk. This is just a "while I'm in here" sort of change, so no big deal if we need to just punt it for later. |
|
VSTS probably won't give an error unless the paths become much longer. I was checking the path lengths by installing a build on Windows and using PowerShell to get the lengths of the longest 10 paths. Once you get a PR going on atom/atom I can check the Windows artifact later and see if we're good. No worries! Thanks for keeping this up to date ⚡ |
|
Ahh, got it - I'll ping you on the PR once it's up.
Think it would be worth committing this somewhere as a script? I could test on my Windows box downstairs too. |
|
Yep, that'd also save me from having to re-remember it every time ;) |
|
Now that I think about it, might be good to have a path length test in the Windows CI script so that we get some indication of how it changes over time and maybe fail the build if it exceeds a predefined goal length we've set. I'll put together something for that later! |
|
Just make sure we don't spend more effort on this than it would take to... fix Squirrel to use Windows long path names. 😆 |
|
I think fixing Squirrel is probably going to be more of a pain, but I haven't tried it yet :) |
|
Just popping in to say this is obsoleted as of #887. |

npm has published a few minor versions since the last upgrade landed. Here are the changelogs:
I don't see anything too critical in there, but it'll help us stay on top of upstream bugfixes 🐛 🔨
Remaining work