Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Keyword highlighting in inheritance list breaks after a new line #232

Closed
sean-mcmanus opened this issue Apr 20, 2017 · 5 comments
Closed
Labels

Comments

@sean-mcmanus
Copy link

Reproed with VS Code - Insiders (they're on the April 7th version). Seems related to #101 .

class b {};
class c {};
class a: public b,
public c
{};
image

@50Wliu 50Wliu added the bug label Apr 20, 2017
@bobbrow
Copy link
Contributor

bobbrow commented May 22, 2017

A similar report (copied from microsoft/vscode-cpptools#748)
@Vultraz

Inherited class names aren't highlighted correctly if they're on a new line

class formatting issue

Virtual keyword in inheritance takes the class name highlighting.

class formatting issue2

@maxbrunsfeld
Copy link
Contributor

This is fixed if you use the new Tree-sitter parsing system, which is enabled by default in Atom 1.32 Beta. If you're not the beta channel, you can enable it by checking the Use Tree-sitter Parsers box in the settings view, or wait for Atom 1.32 Stable to be released. Thanks!

@bobbrow
Copy link
Contributor

bobbrow commented Oct 1, 2018

This issue is about the TextMate grammar as we consume it in VS Code, so we can't just switch to Atom 😉 . Are you essentially saying that the old grammar will not be updated and that VS Code needs to use this new tree-sitter thing instead of TextMate now?

@maxbrunsfeld
Copy link
Contributor

We'll continue to accept PRs that update the text-mate grammar for quite a while probably, but we probably won't prioritize work on these kinds of things ourselves, since Atom is moving away from TextMate for this language.

I'm closing this one out because the bug is fixed on Atom's end by switching grammars, and the Atom team uses issues as a kind of backlog - to keep track of work that we still need to do.

@denis-reichelt

This comment has been minimized.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants