This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
upgrade dependency to address graceful-fs issue #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled upon an obscure issue with this snippet of code under NodeJS
10.7.0
and multiple versions ofts-node
(5.x
and7.x
):Which at runtime would do this:
Searching for that message pointed to a few threads about
graceful-fs
and it's use ofnatives
breaking on future versions of Node: nodejs/node#19786 (comment)And sure enough, I poke at what
yarn list
shows this is one of thelegal-eagle
dependencies:You can work around this in the interim by adding a
resolutions
entry to yourpackage.json
to force it to use a later version ofgraceful-fs
:But this will likely add noise to your logs:
The better fix is to upgrade
read-installed
to a version that usesgraceful-fs
4.x, which this PR does. I wasn't able to reproduce this in isolation, but I'm reasonably happy that the investigations above mean this is a Good Thing To Do™.There weren't any tests to verify against this, but I've tested this version in Desktop (where the problem originated) and confirmed the behaviour is unaffected.
cc @iAmWillShepherd @nerdneha in case you stumbled upon this earlier