Don't show price for test currencies #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marketmaker returns a price for PIZZA, but it doesn't really make sense to show it as it's not real.
|
Marketmaker shouldn't return a price in the first place. @lukechilds If you agree, I'll open a Marketmaker issue, but we still want this PR in the meantime regardless. |
|
Are you sure the price isn't coming from CMC? PIZZA is listed on CMC which is PizzaCoin. An unrelated currency which does have a price. |
lukechilds
approved these changes
May 23, 2018
|
It probably is, since Marketmaker is using CMC too, however, we're already preventing that on our end 52417c0 |
|
Marketmaker issue: jl777/SuperNET#862 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marketmaker returns a price for PIZZA, but it doesn't really make sense to show it as it's not real.