-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new type grubby::kernel_opt #8
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atsonkov
reviewed
Mar 25, 2021
traylenator
force-pushed
the
type
branch
3 times, most recently
from
March 26, 2021 08:24
706d505
to
04067d7
Compare
atsonkov
reviewed
Mar 26, 2021
atsonkov
reviewed
Mar 26, 2021
atsonkov
reviewed
Mar 26, 2021
atsonkov
reviewed
Mar 26, 2021
A new type is added ```puppet grubby::kernel_opt{'foo': ensure => present, value => 'bar', scope => 'ALL', } ``` The previous hash parameter `grubby::kernel_opts` is still valid and now uses `grubby::kernel_opt` internally. Motivation here is to increase flexibility of module allowing kernel parameters to be added by other distinct modules.
And the fact that |
This one is still marked as draft, but looks ready to merge, right? |
atsonkov
approved these changes
Mar 26, 2021
Did some real world tests as I had not for the last few commits.
resulted in:
Following this
So delete two and change one , resulted in
So all good. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new type is added
The previous hash parameter
grubby::kernel_opts
is still validand now uses
grubby::kernel_opt
internally.Motivation here is to increase flexibility of module allowing
kernel parameters to be added by other distinct modules.