Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-commit framework inconsistencies with GA #229

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

unode
Copy link
Collaborator

@unode unode commented Jun 11, 2021

Lints a few cases that were missed before and configures exceptions.

  • black was still trying to lint .py files in unittest snapshots
    • .mypy and other files/folders don't need to be excluded since pre-commit only looks at files tracked by git.
  • pytest was failing to find modules - pre-commit defaults to running in an independent venv. Using system disables that behavior and inherits the environment.
  • docformatter use newer version and do --in-place changes.
    • docformatter is still a little annoying to use. When running locally it automatically fixes things and git tells us what changes but in a GitHub Action the output only tells which file failed not what caused it.

Also lint a few cases that were missed before
@attzonko attzonko merged commit bd0eeab into attzonko:main Jun 11, 2021
@unode unode deleted the pre-commit-round-2 branch June 11, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants