Fix scheduler.once() running multiple times #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneeven
approved these changes
Jun 14, 2021
unode
added a commit
to unode/mmpy_bot
that referenced
this pull request
Aug 19, 2021
This reverts commit d4f78c5. The same bug exists not only in schedule.once() but also schedule.every() so a better fix is necessary.
unode
added a commit
to unode/mmpy_bot
that referenced
this pull request
Aug 19, 2021
This forces code to run sequentially on the scheduler thread. fixes attzonko#231 (again)
unode
added a commit
to unode/mmpy_bot
that referenced
this pull request
Aug 19, 2021
This forces code to run sequentially on the scheduler thread. fixes attzonko#231 (again)
unode
added a commit
to unode/mmpy_bot
that referenced
this pull request
Aug 19, 2021
This forces code to run sequentially on the scheduler thread. fixes attzonko#231 (again)
unode
added a commit
to unode/mmpy_bot
that referenced
this pull request
Aug 19, 2021
This forces code to run sequentially on the scheduler thread. fixes attzonko#231 (again) (cherry picked from commit e393992)
attzonko
pushed a commit
that referenced
this pull request
Aug 29, 2021
* Revert "Fix scheduler.once() running multiple times (#231)" This reverts commit d4f78c5. The same bug exists not only in schedule.once() but also schedule.every() so a better fix is necessary. * Add tests to capture abnormal consecutive execution of scheduled tasks * Test using a threadpool The threadpool already has a dedicated thread to run scheduler tasks which is not the same as running in the main thread. * Disable tests that can't be fixed * The schedule module is not designed to run in a non-blocking fashion This forces code to run sequentially on the scheduler thread. fixes #231 (again)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The included test executes the function 4 times.
The fix overrides should_run preventing the job from being picked up again.
The job will not be retried if it fails to execute.