Implement PluginManager and HelpPlugin #326
Conversation
unode
force-pushed
the
helpplugin
branch
4 times, most recently
from
c1975f0
to
3043712
Compare
This interface splits up code from Plugin and separates the role of EventHandler from Plugins. (cherry picked from commit 91c2fec)
(cherry picked from commit 2e6bf84ab859c5e659c158f33aabbf7d2d026693)
unode
changed the title
|
I don't think I can get rid of the 2 codeclimate issues without making the code harder to read. Also I ended up re-merging the two features in one PR as I couldn't get everything to validate and tests to pass in the in-between state and it was becoming too time consuming. Black was also bumped in this PR as I couldn't run the previous version locally. |
|
@unode Please check to make sure my conflict resolution in function.py did not break anything for you. Otherwise I think we can squash and merge this. EDIT: NVM it did break stuff fixing now |
|
Code Climate has analyzed commit 6c0b55c and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
As all the tests passed, I am pretty sure it is correct, will go ahead and merge. |
* Implement PluginManager interface Co-authored-by: Alex Tzonkov <4975715+attzonko@users.noreply.github.com>
This is an attempt to split #226 into smaller PRs, easier to review.
This PR should be merged after #323 and #325.