Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure Twitter facade resolves as singleton (fixes #349) #352

Merged
merged 1 commit into from
Apr 18, 2021

Conversation

reliq
Copy link
Collaborator

@reliq reliq commented Apr 16, 2021

This ensures that the same instance of accessor is resolved by the twitter facade/contract.

@reliq reliq requested a review from atymic April 16, 2021 14:40
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #352 (4c9dc65) into main (54a87de) will decrease coverage by 0.17%.
The diff coverage is 38.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #352      +/-   ##
============================================
- Coverage     34.87%   34.70%   -0.18%     
- Complexity      358      359       +1     
============================================
  Files            31       31              
  Lines           800      804       +4     
============================================
  Hits            279      279              
- Misses          521      525       +4     
Impacted Files Coverage Δ Complexity Δ
src/ApiV1/Service/Twitter.php 8.33% <0.00%> (-1.67%) 9.00 <1.00> (+1.00) ⬇️
src/Concern/ApiV2Behavior.php 100.00% <ø> (ø) 2.00 <0.00> (ø)
src/Service/Accessor.php 100.00% <100.00%> (ø) 4.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54a87de...4c9dc65. Read the comment docs.

@reliq reliq merged commit b45e4bc into main Apr 18, 2021
@reliq reliq deleted the ensure-twitter-resolves-as-singleton branch April 18, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant