From 350b59295069172f3fe4a445aed1db3dd89ad76d Mon Sep 17 00:00:00 2001 From: "weiran.sun" <907221539@qq.com> Date: Thu, 1 Feb 2024 10:00:27 +0800 Subject: [PATCH] Revert "ADM-777:[frontend]refactor: fix code style for code lint" This reverts commit 7e7dd7559c9e7ad2d73a1d1308532be800199232. --- .../__tests__/hooks/useGetMetricsStepsEffect.test.tsx | 11 ++++++----- .../hooks/useGetPipelineToolInfoEffect.test.tsx | 8 ++++---- .../PipelineMetricSelection/index.tsx | 2 +- frontend/src/hooks/useGetMetricsStepsEffect.ts | 4 ++-- 4 files changed, 13 insertions(+), 12 deletions(-) diff --git a/frontend/__tests__/hooks/useGetMetricsStepsEffect.test.tsx b/frontend/__tests__/hooks/useGetMetricsStepsEffect.test.tsx index 9a728b2e83..e6ae47b14b 100644 --- a/frontend/__tests__/hooks/useGetMetricsStepsEffect.test.tsx +++ b/frontend/__tests__/hooks/useGetMetricsStepsEffect.test.tsx @@ -1,21 +1,22 @@ -import { ContextProvider } from '@src/hooks/useMetricsStepValidationCheckContext'; import { InternalServerException } from '@src/exceptions/InternalServerException'; import { ERROR_MESSAGE_TIME_DURATION, MOCK_GET_STEPS_PARAMS } from '../fixtures'; import { useGetMetricsStepsEffect } from '@src/hooks/useGetMetricsStepsEffect'; import { metricsClient } from '@src/clients/MetricsClient'; import { act, renderHook } from '@testing-library/react'; -import { setupStore } from '@test/utils/setupStoreUtil'; -import { Provider } from 'react-redux'; import { HttpStatusCode } from 'axios'; +import {setupStore} from "@test/utils/setupStoreUtil"; +import {Provider} from "react-redux"; +import {ContextProvider} from "@src/hooks/useMetricsStepValidationCheckContext"; +import React from "react"; const setup = () => { const store = setupStore(); - const wrapper = ({ children }: { children: React.ReactNode }) => ( + const wrapper = ({children}: { children: React.ReactNode }) => ( {children} ); - return renderHook(() => useGetMetricsStepsEffect(), { wrapper }); + return renderHook(() => useGetMetricsStepsEffect(), {wrapper}); }; describe('use get steps effect', () => { diff --git a/frontend/__tests__/hooks/useGetPipelineToolInfoEffect.test.tsx b/frontend/__tests__/hooks/useGetPipelineToolInfoEffect.test.tsx index 7baecfa124..2a85e82e95 100644 --- a/frontend/__tests__/hooks/useGetPipelineToolInfoEffect.test.tsx +++ b/frontend/__tests__/hooks/useGetPipelineToolInfoEffect.test.tsx @@ -1,14 +1,14 @@ import { useGetPipelineToolInfoEffect } from '@src/hooks/useGetPipelineToolInfoEffect'; -import { updatePipelineToolShouldCallInfoApi } from '@src/context/config/configSlice'; import { pipelineToolClient } from '@src/clients/pipeline/PipelineToolClient'; import { MOCK_BUILD_KITE_GET_INFO_RESPONSE } from '../fixtures'; import { renderHook, waitFor } from '@testing-library/react'; import { setupStore } from '../utils/setupStoreUtil'; -import { act } from 'react-dom/test-utils'; import { Provider } from 'react-redux'; import { HttpStatusCode } from 'axios'; import { ReactNode } from 'react'; import React from 'react'; +import {act} from "react-dom/test-utils"; +import { updatePipelineToolShouldCallInfoApi } from "@src/context/config/configSlice"; const mockDispatch = jest.fn(); jest.mock('react-redux', () => ({ @@ -50,7 +50,7 @@ beforeEach(() => { describe('use get pipelineTool info side effect', () => { it('should return immediately if shouldCallApi is false', async () => { const store = setupStore(); - const Wrapper = ({ children }: { children: ReactNode }) => { + const Wrapper = ({children}: { children: ReactNode }) => { return {children}; }; @@ -58,7 +58,7 @@ describe('use get pipelineTool info side effect', () => { store.dispatch(updatePipelineToolShouldCallInfoApi(false)); }); - const { result } = renderHook(() => useGetPipelineToolInfoEffect(), { wrapper: Wrapper }); + const {result} = renderHook(() => useGetPipelineToolInfoEffect(), {wrapper: Wrapper}); act(() => { result.current.apiCallFunc(); diff --git a/frontend/src/containers/MetricsStep/DeploymentFrequencySettings/PipelineMetricSelection/index.tsx b/frontend/src/containers/MetricsStep/DeploymentFrequencySettings/PipelineMetricSelection/index.tsx index 5261e566c4..87b2ed57fb 100644 --- a/frontend/src/containers/MetricsStep/DeploymentFrequencySettings/PipelineMetricSelection/index.tsx +++ b/frontend/src/containers/MetricsStep/DeploymentFrequencySettings/PipelineMetricSelection/index.tsx @@ -18,9 +18,9 @@ import { ButtonWrapper, PipelineMetricSelectionWrapper, RemoveButton, WarningMes import { WarningNotification } from '@src/components/Common/WarningNotification'; import { useGetMetricsStepsEffect } from '@src/hooks/useGetMetricsStepsEffect'; import { ErrorNotification } from '@src/components/ErrorNotification'; -import { useAppDispatch, useAppSelector } from '@src/hooks'; import { MESSAGE } from '@src/constants/resources'; import { Loading } from '@src/components/Loading'; +import { useAppDispatch, useAppSelector} from '@src/hooks'; import { store } from '@src/store'; import { useState } from 'react'; diff --git a/frontend/src/hooks/useGetMetricsStepsEffect.ts b/frontend/src/hooks/useGetMetricsStepsEffect.ts index 175501d6a1..ab6fd541a5 100644 --- a/frontend/src/hooks/useGetMetricsStepsEffect.ts +++ b/frontend/src/hooks/useGetMetricsStepsEffect.ts @@ -1,9 +1,9 @@ -import { shouldCallStepApi, updatePipelineToolShouldCallStepApi } from '@src/context/config/configSlice'; import { getStepsParams, metricsClient } from '@src/clients/MetricsClient'; -import { useAppDispatch, useAppSelector } from '@src/hooks/index'; import { MESSAGE } from '@src/constants/resources'; import { DURATION } from '@src/constants/commons'; import { useState } from 'react'; +import { shouldCallStepApi, updatePipelineToolShouldCallStepApi } from "@src/context/config/configSlice"; +import { useAppDispatch, useAppSelector } from "@src/hooks/index"; export interface useGetMetricsStepsEffectInterface { getSteps: (