Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADM-620:[frontend]fix: fix regular to swagger in middle #793

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

BoBoDai
Copy link

@BoBoDai BoBoDai commented Dec 6, 2023

Summary

...

Before

Description

Screenshots
If applicable, add screenshots to help explain behavior of your code.

After

Description

Screenshots
If applicable, add screenshots to help explain behavior of your code.

Note

Null

Copy link

github-actions bot commented Dec 6, 2023

Hi @BoBoDai! 👋
Thank you for submitting a pull request! We appreciate your contribution and will review your changes as soon as possible.

Copy link
Collaborator

@guzhongren guzhongren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, we can't access swagger in the public network,
coc the React router of the frontend.
if you are right, please give us a screenshot in the PR, you can test it locally, not test it in SIT/PROD env.

@BoBoDai
Copy link
Author

BoBoDai commented Dec 7, 2023

Ok,
In fact, our nginx has opened the backend interface. Normally, it can be accessed directly through "/api/v1/docs".
At local testing is also consistent with this situation.
1
nginx.conf
2
web

But we also have a regular location that will intercept all links with any file format suffix.
3
nginx.conf
4
web

If we add a regular for swagger, we can block the previous regular. After that, we can access swagger normally.
5
nginx.conf
6
web

Copy link

codacy-production bot commented Dec 7, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d568f08) 4333 4333 100.00%
Head commit (bc44d60) 8666 (+4333) 8666 (+4333) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#793) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@guzhongren guzhongren merged commit 95281a3 into main Dec 7, 2023
36 checks passed
@guzhongren guzhongren deleted the ADM-620-nginx branch December 7, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants