Make MAC addresses build-time configurable, #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to be that MAC addresses were hardcoded to 52:54:01:00:00, 52:54:01:00:0A, etc. Now you can specify -DMAC_BASE_ADDRESS=0x5254010000 to the C compiler to get the same effect. You must use the same MAC_BASE_ADDRESS for all components. Signed-off-by: Peter Chubb <peter.chubb@unsw.edu.au>
wom-bat
force-pushed
the
random_mac_address
branch
from
21a609e
to
0a14da1
Compare
Use the same default as before. Signed-off-by: Peter Chubb <peter.chubb@unsw.edu.au>
wom-bat
force-pushed
the
random_mac_address
branch
from
f9cf66e
to
f63e81a
Compare
|
I'd like to get this in since we keep having MAC address clashes when we're developing at the same time in the lab. Would you mind rebasing it and the LionsOS one? Will try merge before any more conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to be that MAC addresses were hardcoded to 52:54:01:00:00, 52:54:01:00:0A, etc.
Now you can specify -DMAC_BASE_ADDRESS=0x5254010000 to the C compiler to get the same effect.
You must use the same MAC_BASE_ADDRESS for all components.
This is referenced by au-ts/lionsos#10