CLI-less webpack build #1105

Sayan751 · 2019-05-23T04:02:15Z

This PR resolves #1098.

Summary of changes:

Parameters consolidations and other minor changes in webpack.config.js. Removed the limiting options from ts-loader as it prevents compiling *.spec.ts files during test with karma(+webpack).
Replaced the au build and run scripts with npm scripts. Affected areas: package.json, aurelia_project/tasks, and release check tests. For pre-build cleanup activity, there is a small gulpfile introduced.
Changed tsconfig.json to have typeroots applied for all cases, without that the release checks were failing for couple of suites. Other changes here enable loading a json file with ES6 import syntax.
Lastly converted the environment.tss to json files, which are loaded using the app-settings-loader.

Tried a different approach to tackle the enviroment configurations. Instead of a typescript file, which is replaced based on the environment, this strategy uses json file to hold the configuration. The loader takes the basic config file and applies that environmentspecific changes (change environment.json and environment.production.json).

These are not needed anymore, as webpack and webpack-dev-server CLIs are directly used to build and run the app.

- Moved the environment jsons to another directory - Added options to load json modules in tsconfig - Changed the imports for environment - Lastly cleaned up loader with external package

Removed limiting options, so that ts-loader can compilespec.ts files during tests.

3cp

One more question, I didn't see you remove aurelia-cli from final package.json of webpack app. Is unit tests still using au test command?

skeleton/common/tsconfig.json__if_typescript

build/tasks/release-checks/tests/generic/au-cypress.js

3cp · 2019-05-23T04:23:32Z

skeleton/webpack/webpack.config.js

      },
      // @endif
      // @if feat.typescript
-      { test: /\.ts$/, loader: "ts-loader", options: { reportFiles: [ srcDir+'/**/*.ts'] }, include: srcDir },


I think you accidentally removed this line from master.

Ok, saw your commit message for this one too. I guess the side effect is that you have to turn on typeRoots unconditionally, which is not idea.

My earlier take on the typeRoots involving monorepo might be little bit premature, as I have not recently tried to create a monorepo for a aurelia project. I tried that that a year back, and there were massive problems with resolving/loading symlinked packages; the webpack config was crowded with aliases. If this is a blocker, I will try to create a lerna prototype, and report the the findings.

I tried to create a monorepo using au-cli and lerna. I couldn't make it work. It is not really because of the type definition, which makes the problem I suspected earlier. But even after fixing the typeRoots, Aurelia has problems loading the custom elements coming from different plugins. I opened an issue before on similar problem. I think the problems related to loading the symlinked packages needs to corrected before starting with bootstrapping lerna monorepo projects with lerna.

On the other hand, this typing issue with Jasmine is already opened here: DefinitelyTyped/DefinitelyTyped#14569. If type definition of jasmine is got resolved, probably the whole typeRoots thing can be done away with.

I also discovered another bug with limiting ts-loader include. I am running release-check on v1 candidate, where I need to modify it to include: karma ? [srcDir, testDir] : srcDir to fix webpack+karma setup.

Yes, I faced that too. Otherwise the *.spec.ts files are never processed, and webpack throws error. I think not having the include for ts-loader is far easier solution.

I see. I will retain the "include" for v1 release. Then we can work on your big refactoring after v1.

3cp · 2019-05-23T04:27:31Z

skeleton/common/tsconfig.json__if_typescript

@@ -32,10 +32,8 @@
    "types": ["node", "jest"],
    // @endif

-    // @if feat.webpack && feat['postcss-typical'] && feat.protractor


I think you accidentally removed some lines?

Ok, I saw your commit message. But we did this conditional typeRoots to do minimum impact for users of lerna (where "./node_modules/@types" does not work).

3cp · 2019-05-23T04:47:32Z

Sidenote: this is technically a breaking change for webpack app. But it's practically not a breaking change, because it doesn't affect/break existing webpack apps. This only affects newly created webpack app.

Sayan751 · 2019-05-23T05:55:44Z

One more question, I didn't see you remove aurelia-cli from final package.json of webpack app. Is unit tests still using au test command?

Yup, those are still based on au test. But it can also be encapsulated in a npm script. As I was focusing on webpack, I actually paid no attention to that.

3cp · 2019-05-23T05:57:57Z

I thought our target is to remove runtime dependency on aurelia-cli for webpack app.

Sayan751 · 2019-05-23T06:10:01Z

I thought our target is to remove runtime dependency on aurelia-cli for webpack app.

I misunderstood it to be a task to remove the au run, and au build for webpack projects. It makes more sense to remove all au flavored commands from webpack apps. I would suggest to have that in a different PR, as this is already quite big. A new PR might also be easy to review. We can still use the same issue to track that.

3cp · 2019-05-23T06:12:53Z

No rush, we appreciate your work on this. As this is likely a post-v1 improvement, you have plenty of time.

3cp · 2019-05-23T06:15:09Z

BTW, please follow the commit message convention to be properly logged in changelog and release note. https://github.com/DurandalProject/about/blob/master/CONTRIBUTING.md#commit

Sayan751 · 2019-05-23T06:21:14Z

Missed the git commit message guideline clearly. Will adhere to that in following commits.

3cp · 2019-05-23T06:53:19Z

You can squash all commits into one if you want, that can avoid some similar entries from multiple commits in changelog.

Usage of aurelia-cli is removed from building and running the webpack apps. This gives developers more control over webpack, and a way to easily change the configuration, without aurelia-cli meddling in between. The commands `au run` or `au build` will not work anymore in the webpack apps, use `npm start`, or `npm run build` instead. This commit closes the webpack part of the the issue aurelia#1098.

Sayan751 · 2019-05-25T12:29:53Z

@3cp @fkleuver It is ready for review again.

Sayan751 · 2019-05-26T09:53:10Z

Just wanted to point out that this pull request sort of addresses #1039 as well.

3cp · 2019-05-28T04:08:08Z

FYI, it's not <feat>(topic):, it's just feat(topic):.

alexdresko · 2019-07-05T13:27:01Z

bump

fkleuver · 2019-07-12T01:59:13Z

@Sayan751 can you rewrite that one commit message with feat to follow conventional commit guidelines please? only then will it correctly show up in generated changelogs
I can't really comment much on the contents, @3cp what are your thoughts at this point?

3cp · 2019-07-12T02:08:57Z

We need to polish it up, and have some kind of plan to handle this kind of breaking change.

We (Sayan included) are all bit busy with Aurelia 2 😅 , not spending enough energy here.

Sayan751 · 2019-07-12T03:49:47Z

@fkleuver @3cp I can try to squash all the commits to one with conventional commit message and force push, if that is ok?

3cp · 2019-07-12T03:53:09Z

Force push is fine.

Sayan751 · 2019-07-13T06:21:44Z

@fkleuver @3cp I tried to squash all the changes, but there are many conflicting changes. These changes have got pretty old and the fork got also out of sync. I think at this point it is best to create a new PR. I have started another branch that contains all the changes squashed into one commit that includes your suggestions. That branch is also synced with the Aurelia master. Currently I am running the release checks, once that is done, I would like to create a new PR and close this one. Let me if you think otherwise.

Sayan751 · 2019-07-13T07:56:27Z

Closed in favor of #1137

alexdresko · 2019-07-13T21:37:28Z

So can this be used now?

Sayan751 · 2019-07-14T04:11:09Z

Sorry @alexdresko you need to wait till #1137 is merged and published.

alexdresko · 2019-09-11T18:54:01Z

@Sayan751 Okay now can we use this? :)

Sayan751 added 13 commits May 16, 2019 00:01

Added a gulp file to clear the dist

3132d35

added default npm scripts to generate

e3df5f4

Added readme with new npm scripts

99d1181

Removed the build and run script

9e0cece

These are not needed anymore, as webpack and webpack-dev-server CLIs are directly used to build and run the app.

Fixing environment json loader

bcd830b

- Moved the environment jsons to another directory - Added options to load json modules in tsconfig - Changed the imports for environment - Lastly cleaned up loader with external package

fixed the gulp file

2e728aa

replaced 'au run' with 'npm start' - release check

7be19b5

removed 'au run' with 'npm start' - cypress check

4b43a3a

Added a different port fot dotnet-core

3494888

correcting the npm start script

a4511aa

changed ts-loader

55a0f5d

Removed limiting options, so that ts-loader can compilespec.ts files during tests.

enabled typeroots for all

aa4d785

3cp reviewed May 23, 2019

View reviewed changes

Sayan751 added 4 commits May 23, 2019 16:37

Post review changes aurelia#1

015d344

fixed import

da3379f

Merge branch 'master' of https://github.com/Sayan751/cli

4461e6c

3cp mentioned this pull request Jul 7, 2019

npx webpack fails immediately after au new #1134

Closed

Sayan751 mentioned this pull request Jul 13, 2019

feat(webpack):enable CLI-less webpack build + run #1137

Merged

Sayan751 closed this Jul 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLI-less webpack build #1105

CLI-less webpack build #1105

Sayan751 commented May 23, 2019 •

edited

Loading

3cp left a comment

3cp May 23, 2019

3cp May 23, 2019

Sayan751 May 23, 2019

Sayan751 May 25, 2019

3cp May 28, 2019

Sayan751 May 28, 2019

3cp May 28, 2019

3cp May 23, 2019

3cp May 23, 2019

3cp commented May 23, 2019

Sayan751 commented May 23, 2019

3cp commented May 23, 2019

Sayan751 commented May 23, 2019

3cp commented May 23, 2019

3cp commented May 23, 2019

Sayan751 commented May 23, 2019

3cp commented May 23, 2019

Sayan751 commented May 25, 2019

Sayan751 commented May 26, 2019

3cp commented May 28, 2019

alexdresko commented Jul 5, 2019

fkleuver commented Jul 12, 2019

3cp commented Jul 12, 2019

Sayan751 commented Jul 12, 2019

3cp commented Jul 12, 2019

Sayan751 commented Jul 13, 2019

Sayan751 commented Jul 13, 2019

alexdresko commented Jul 13, 2019

Sayan751 commented Jul 14, 2019

alexdresko commented Sep 11, 2019

CLI-less webpack build #1105

CLI-less webpack build #1105

Conversation

Sayan751 commented May 23, 2019 • edited Loading

3cp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

3cp commented May 23, 2019

Sayan751 commented May 23, 2019

3cp commented May 23, 2019

Sayan751 commented May 23, 2019

3cp commented May 23, 2019

3cp commented May 23, 2019

Sayan751 commented May 23, 2019

3cp commented May 23, 2019

Sayan751 commented May 25, 2019

Sayan751 commented May 26, 2019

3cp commented May 28, 2019

alexdresko commented Jul 5, 2019

fkleuver commented Jul 12, 2019

3cp commented Jul 12, 2019

Sayan751 commented Jul 12, 2019

3cp commented Jul 12, 2019

Sayan751 commented Jul 13, 2019

Sayan751 commented Jul 13, 2019

alexdresko commented Jul 13, 2019

Sayan751 commented Jul 14, 2019

alexdresko commented Sep 11, 2019

Sayan751 commented May 23, 2019 •

edited

Loading