fix(BehaviorPropertyObserver): use Object.is() for comparison #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bigopon Can you remind me which browsers will cause the polyfill to kick in for the above scenario? |
|
Seems like it only affects IE, which is fine with me. Will get this in shortly! |
|
According to this https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/is It should be also Safari < 9 |
src/behavior-property-observer.js
Outdated
| @@ -38,7 +38,7 @@ export class BehaviorPropertyObserver { | |||
| setValue(newValue: any): void { | |||
| let oldValue = this.currentValue; | |||
|
|
|||
| if (oldValue !== newValue) { | |||
| if (Object.is(newValue, oldValue)) { | |||
There was a problem hiding this comment.
@bigopon Should there be a ! in front of this?
There was a problem hiding this comment.
Yes, it's fixed. Thanks for catching that @EisenbergEffect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance shouldn't take any hit with native
Object.isimplementation, app using polyfill ofObject.iswill. Overall won't be a big deal and Aurelia will be more reliable as comparison betweenNaN,+0,-0will no longer an issue.