Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BehaviorPropertyObserver): use Object.is() for comparison #598

Merged
merged 2 commits into from
Jun 20, 2018
Merged

fix(BehaviorPropertyObserver): use Object.is() for comparison #598

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf8ec9a
fix(BehaviorPropertyObserver): use Object.is() for comparison
bigopon Jan 23, 2018
b0366ab
Fix wrong if condition
bigopon Jun 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/behavior-property-observer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export class BehaviorPropertyObserver {
setValue(newValue: any): void {
let oldValue = this.currentValue;

if (oldValue !== newValue) {
if (Object.is(newValue, oldValue)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bigopon Should there be a ! in front of this?

Copy link
Member Author

@bigopon bigopon Jun 19, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's fixed. Thanks for catching that @EisenbergEffect

this.oldValue = oldValue;
this.currentValue = newValue;

Expand All @@ -62,7 +62,7 @@ export class BehaviorPropertyObserver {

this.notqueued = true;

if (newValue === oldValue) {
if (Object.is(newValue, oldValue)) {
return;
}

Expand Down