Sync Tenant Flags with API v2 #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikprijck
changed the title
frederikprijck
commented
Feb 1, 2021
| settingsUpdateResponse.Flags.DisableClickjackProtectionHeaders.Should().BeTrue(); | ||
| settingsUpdateResponse.Flags.EnableAPIsSection.Should().BeTrue(); | ||
| settingsUpdateResponse.Flags.EnableClientConnections.Should().BeFalse(); | ||
| settingsUpdateResponse.Flags.EnablePipeline2.Should().BeTrue(); |
There was a problem hiding this comment.
Previously we could do a full object comparison, because a lot of properties where not included.
Now, this is not the case anymore as it might be that the values of certain flags are already set to true/false in the Database, while they are not part of the update call here. So the flags we are sent are not identical to the flags we are retrieving.
Example:
Database:
- Flag 1: true
- Flag 2: false
Update call:
- Set Flag 2 to true
- Pass Flag 1 as NULL to not update it
Response:
- Flag 1: true
- Flag 2: true
frederikprijck
changed the title
stevehobbsdev
requested changes
Feb 1, 2021
stevehobbsdev
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR syncs the TenantFlags class with the available flags on the API v2 based on https://auth0.com/docs/api/management/v2#!/Tenants/get_settings
Closes #465