This repository was archived by the owner on May 15, 2024. It is now read-only.
Improve response error handling - Fixes auth0 Issue 12 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests for the new error handling.
lmarkscp
changed the title
lmarkscp
changed the title
ndowmon
approved these changes
Feb 16, 2023
SeaBlooms
approved these changes
Feb 16, 2023
|
@gvauter can this be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current handling of API response error(s) in
JupiterOneClient._execute_query, besides the status codes 429 and 503, expects the response content to be JSON, but that isn't always the case, such as 401 Unauthorized. This caused a JSONDecodeError to be thrown instead which obfuscated the actual error in the API response in which the content type was not application/json.Added handling of 401 and other responses that aren't JSON.
Added tests for the new error handling.
References
auth0#12
Testing
I updated the pytests in test_client.py, but manual tests just require using a bogus account or token.
Checklist
master