-
Notifications
You must be signed in to change notification settings - Fork 143
Redirect using Laravel framework #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect using Laravel framework #140
Conversation
Also, by binding them both to your container you can extend or overwrite the behaviour a bit more easily. Which should help with testing or implemting different auth flows.
Use LaravelSessionStore in the SessionStateHandler.
Explicitly save session
Since I broke that in my previous commit
Since we now let the Framework exit the session and cookie middleware can take care of that again
|
@nstapelbroek - Thanks for this! Instead of recreating all the behavior in the SDK, do you think it would be more helpful to us to add a method to the SDK that just builds out the authorization URL and hands it back? I can use the same method in the core |
|
@nstapelbroek - Alright, I put through a PR on the PHP SDK that should help with this: You get use that new Probably best to back all the session changes out of this one and keep #135 as-is. That way we can get all this working with no backwards-incompatible changes! Feel free to provide any feedback you have on the PR linked above, otherwise we'll get that reviewed/merged/released ASAP. Thank you once again! |
|
No longer needed because we found a better way in #135 |
Changes
Heya 👋, This PR will introduce backwards incompatible changes I left out in #135. Let me know what you think.
Concrete changes:
loginmethod so we can wrap the redirect in a RedirectResponse.Result is that brand new sessions that start on a
/loginwill now work because the redirect response returned wil haveset-cookieheaders.References
#135
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
[ ] This change has been tested on the latest version Laravel
Checklist
[x] I have read the Auth0 general contribution guidelines
[x] I have read the Auth0 Code of Conduct